From 08e681b63c357f839cef5b65ead1e20984743f79 Mon Sep 17 00:00:00 2001
From: Bart Arendarczyk <s1924442@ed.ac.uk>
Date: Fri, 4 Oct 2024 11:36:31 +0100
Subject: [PATCH] Fixed incorrect GCR calculation.
---
src/ac/ed/lurg/solar/SolarPotentialItem.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/ac/ed/lurg/solar/SolarPotentialItem.java b/src/ac/ed/lurg/solar/SolarPotentialItem.java
index f65e5faf..daafad4c 100644
--- a/src/ac/ed/lurg/solar/SolarPotentialItem.java
+++ b/src/ac/ed/lurg/solar/SolarPotentialItem.java
@@ -38,7 +38,7 @@ public class SolarPotentialItem implements RasterItem {
public void calcOptimalGCR(double latitude) {
// https://doi.org/10.1016/j.solener.2023.04.038
// Optimal panel spacing and therefore Ground Coverage ratio depends on latitude
- this.optimalGCR = -0.55 / (1 + Math.exp(-0.138 * (latitude - 43.4))) + 0.71;
+ this.optimalGCR = -0.55 / (1 + Math.exp(-0.138 * (Math.abs(latitude) - 43.4))) + 0.71;
this.agrivoltaicsGCR = ModelConfig.AV_GCR;
}
--
GitLab