Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
L
lammps
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
multiscale
lammps
Commits
d2846404
Commit
d2846404
authored
6 years ago
by
Axel Kohlmeyer
Browse files
Options
Downloads
Patches
Plain Diff
update development workflow description to state of latest discussions
parent
1d6bf1ea
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
doc/github-development-workflow.md
+11
-8
11 additions, 8 deletions
doc/github-development-workflow.md
with
11 additions
and
8 deletions
doc/github-development-workflow.md
+
11
−
8
View file @
d2846404
...
@@ -50,8 +50,8 @@ This is indicated by who the pull request is assigned to. LAMMPS core
...
@@ -50,8 +50,8 @@ This is indicated by who the pull request is assigned to. LAMMPS core
developers can self-assign or they can decide to assign a pull request
developers can self-assign or they can decide to assign a pull request
to a different LAMMPS developer. Being assigned to a pull request means,
to a different LAMMPS developer. Being assigned to a pull request means,
that this pull request may need some work and the assignee is tasked to
that this pull request may need some work and the assignee is tasked to
determine wh
at
this might be needed or not, and may either implement
the
determine wh
ether
this might be needed or not, and may either implement
required changes or ask the submitter of the pull request to implement
the
required changes or ask the submitter of the pull request to implement
them. Even though, all LAMMPS developers may have write access to pull
them. Even though, all LAMMPS developers may have write access to pull
requests (if enabled by the submitter, which is the default), only the
requests (if enabled by the submitter, which is the default), only the
submitter or the assignee of a pull request may do so. During this
submitter or the assignee of a pull request may do so. During this
...
@@ -76,12 +76,15 @@ People can be assigned to review a pull request in two ways:
...
@@ -76,12 +76,15 @@ People can be assigned to review a pull request in two ways:
Reviewers are requested to state their appraisal of the proposed changes
Reviewers are requested to state their appraisal of the proposed changes
and either approve or request changes. People may unassign themselves
and either approve or request changes. People may unassign themselves
from review, if they feel not competent about the changes proposed. At
from review, if they feel not competent about the changes proposed. At
least one review from a LAMMPS developer with write access is required
least two approvals from LAMMPS developers with write access are required
before merging in addition to the automated compilation tests. The
before merging in addition to the automated compilation tests.
feature, that reviews from code owners are "hard" reviews (i.e. they
Merging counts as implicit approval, so does submission of a pull request
must all be approved before merging is allowed), is currently disabled
(by a LAMMPS developer). So the person doing the merge may not also submit
and it is in the discretion of the merge maintainer to assess when
an approving review. The feature, that reviews from code owners are "hard"
a sufficient degree of approval has been reached. Reviews may be
reviews (i.e. they must all be approved before merging is allowed), is
currently disabled and it is in the discretion of the merge maintainer to
assess when a sufficient degree of approval, especially from external
contributors, has been reached in these cases. Reviews may be
(automatically) dismissed, when the reviewed code has been changed,
(automatically) dismissed, when the reviewed code has been changed,
and then approval is required a second time.
and then approval is required a second time.
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment