Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
L
lammps
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
multiscale
lammps
Commits
e1603763
Commit
e1603763
authored
6 years ago
by
Axel Kohlmeyer
Browse files
Options
Downloads
Patches
Plain Diff
incomplete first draft. committed for checking the markup in github.
parent
952e5298
No related branches found
Branches containing commit
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
doc/github-development-workflow.md
+82
-0
82 additions, 0 deletions
doc/github-development-workflow.md
with
82 additions
and
0 deletions
doc/github-development-workflow.md
0 → 100644
+
82
−
0
View file @
e1603763
# Outline of the GitHub Development Workflow
This purpose of this document is to provide a point of reference for the
core LAMMPS developers and other LAMMPS contibutors to understand the
choices the LAMMPS developers have agreed on. Git and GitHub provide the
tools, but do not set policies, so it is up to the developers to come to
an agreement as to how to define and interpret policies. This document
is likely to change as our experiences and needs change and we try to
adapt accordingly. Last change 2018-11-15.
## Table of Contents
*
[
GitHub Merge Management
](
#github-merge-management
)
*
[
Pull Requests
](
#pull-requests
)
*
[
Pull Request Assignments
](
#pull-request-assignments
)
*
[
Pull Request Reviews
](
#pull-request-reviews
)
*
[
Pull Request Discussions
](
#pull-request-discussions
)
*
[
Checklist for Pull Requests
](
#checklist-for-pull-requests
)
*
[
GitHub Issues
](
#github-issues
)
*
[
Feature Request Issues
](
#feature-request-issues
)
*
[
Bug Report Issues
](
#bug-report-issues
)
*
[
Milestones and Release Planning
](
#milestones-and-release-planning
)
## GitHub Merge Management
In the interest of consistency, ONLY ONE of the core LAMMPS developers
should doing the merging itself. This is currently @akohlmey (Axel
Kohlmeyer). If this assignment needs to be changed, it shall be done
right after a stable release.
## Pull Requests
ALL changes to the LAMMPS code and documentation, however trivial, MUST
be submitted as a pull request to GitHub. All changes to the "master"
branch must be made exclusively through merging pull requests. The
"unstable" and "stable" branches are only to be updated upon patch or
stable releases with fast-forward merges based on the associated
tags. Pull requests may also be submitted to (long-running) feature
branches created by LAMMPS developers inside the LAMMPS project, if
needed. Those are not subject to the merge and review restrictions
discussed in this document, though.
### Pull Request Assignments
Pull requests can be "chaperoned" by one of the LAMMPS core developers.
This is indicated by who the pull request is assigned to. LAMMPS core
developers can self-assign or they can decide to assign a pull request
to a different LAMMPS developer. Being assigned to a pull request means,
that this pull request may need some work and the assignee is tasked to
determine what this might be needed or not, and may either implement the
required changes or ask the submitter of the pull request to implement
them. Even though, all LAMMPS developers may have write access to pull
requests (if enabled by the submitter, which is the default), only the
submitter or the assignee of a pull request may do so. During this
period the "work_in_progress" label shall be applied to the pull
request. The assignee gets to decide what happens to the pull request
next, e.g. whether it should be assigned to a different developer for
additional checks and changes, or is recommended to be merged. Removing
the "work_in_progress" label and assigning the pull request to the
developer tasked with merging signals that a pull request is ready to be
merged.
### Pull Request Reviews
People can be assigned to review a pull request in two ways:
*
They can be assigned manually to review a pull request
by the submitter or a LAMMPS developer
*
They can be automatically assigned, because
developer
### Pull Request Discussions
### Checklist for Pull Requests
## GitHub Issues
### Feature Request Issues
### Bug Report Issues
## Milestones and Release Planning
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment