-
- Downloads
[WIP] fix!(agora): pipeline handles experiments with new logfile format
WHY IS THIS CHANGE NEEDED?: - aliby pipeline is not configured to deal with new logfile format produced by MultiDPy HOW DOES THE CHANGE SOLVE THE PROBLEM?: - this is a quick-and-dirty fix (basically, grafting a temporary/workaround solution) so that the relevant experiment can be segmented before a deadline - put the parser in https://git.ecdf.ed.ac.uk/swain-lab/aliby/skeletons/-/blob/cdf3699d8c802ea908c18197fe84d7e25f2e41ce/scripts/dev/slim_newlogfile.py into a new module. - wrote parse_newlogfiles() in agora.io.metadata based on parse_logfiles() to call the parser for the new logfile - redefined load_logs() in aliby.pipeline to use parse_newlogfiles() WHAT SIDE EFFECTS DOES THIS CHANGE HAVE?: - breaks: pipeline now unable to parse original logfiles - tech debt: grafting a solution written without consideration of the existing design of metadata. no coherence of how the grammar & functions are written. ideally, we should have a set of grammar JSON files that the user can choose for a parser. - bkwds compat: user must specify tiler parameters when running segmentation, i.e. params = PipelineParameters.default(general={ ..... }) params.tiler = {"tile_size": 117, "ref_channel": "brightfield1", "ref_z": 0} p = Pipeline(params) p.run() this is because the new logfile format uses a different name for the reference channel, which is usually 'Brightfield' overall, this is intended to be a temporary solution EVIDENCE THAT COMMIT WORKS: - tested by running skeletons/scripts/essential/run.py on experiment staffa:470, which uses the new logfile format - this commit doesn't actually solve all problems -- now encountering a ValueError that aborts segmentation (see references below). at least i think it solves all salient problems that i think are directly caused by a different logfile format REFERENCES: - issue #38 - the ValueError: aliby#38 (comment 113221)
src/logfile_parser/newlogfile_parser.py
0 → 100644
Please register or sign in to comment