Skip to content
Snippets Groups Projects
Commit f192bb9e authored by Arin Wongprommoon's avatar Arin Wongprommoon
Browse files

feat!(core): Change behaviour of detrend process

WHY IS THIS CHANGE NEEDED?:
- process currently first normalises by dividing by mean -- not strictly
  part of detrending
- process divides normalised time series by moving average -- difficult
  to justify as poor evidence for signal's trend being multiplicative to
  phenomenon of interest

HOW DOES THE CHANGE SOLVE THE PROBLEM?:
- remove normalising step
- subtract moving average instead of dividing

WHAT SIDE EFFECTS DOES THIS CHANGE HAVE?:
- change is not backwards compatible
- does not affect aliby, agora, or the rest of postprocessor as none
  depend on detrend
- will affect skeletons/arin as modules & scripts rely on detrending as
  part of time series pre-processing -- but qualitatively little changes

EVIDENCE THAT COMMIT WORKS:
- testing on skeletons/arin/strain report script and inspecting output
  plots -- still makes sense

REFERENCES:
- issue #22
parent f74f8944
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment