Skip to content
Snippets Groups Projects
  1. Jan 04, 2023
  2. Dec 20, 2022
  3. Oct 17, 2022
    • Arin Wongprommoon's avatar
      fix(postproc): group signals apart from GFP · f2102851
      Arin Wongprommoon authored
      WHY IS THIS CHANGE NEEDED?:
      - IndexError raised when NameGrouper used to define a grouper object
        and then when .concat_signal() was invoked
      
      HOW DOES THE CHANGE SOLVE THE PROBLEM?:
      - effectively reverted to aliby@252915c6
      - the two commits leading up to that one solved the problem: first by
        changing chainer's assumption that all experiments have a GFP channel,
        then updated references to renamed variables
      
      WHAT SIDE EFFECTS DOES THIS CHANGE HAVE?:
      - risks: may have broken somewhere upstream not otherwise specified yet
      
      EVIDENCE THAT COMMIT WORKS:
      - running grouper works
      
      REFERENCES:
      - issue #35
      f2102851
  4. Oct 14, 2022
  5. Oct 11, 2022
    • Arin Wongprommoon's avatar
      fix(extraction): define candidate channels · 252915c6
      Arin Wongprommoon authored
      WHY IS THIS CHANGE NEEDED?:
      - invoked grouper (which used chainer, which in turn is based on
        Signal), encountered AttributeError: 'Chainer' object has no
        attributes 'candidate_channels'
      
      HOW DOES THE CHANGE SOLVE THE PROBLEM?:
      - chainer used to rely on av_channels in
        extraction/core/functions/defaults.py, so renamed that to
        candidate_channels
      - added a candidate_channels attribute to Signal object to fulfil references
      252915c6
  6. Oct 04, 2022
  7. Sep 30, 2022
  8. Sep 29, 2022
  9. Sep 28, 2022
  10. Sep 26, 2022
  11. Sep 24, 2022
Loading