Skip to content
Snippets Groups Projects
  1. Mar 02, 2023
  2. Feb 06, 2023
  3. Jan 26, 2023
  4. Jan 24, 2023
  5. Jan 13, 2023
  6. Jan 12, 2023
  7. Jan 11, 2023
  8. Jan 10, 2023
  9. Oct 23, 2022
  10. Oct 17, 2022
    • Alán Muñoz's avatar
      27b9c3f6
    • Arin Wongprommoon's avatar
      fix(postproc): group signals apart from GFP · f2102851
      Arin Wongprommoon authored
      WHY IS THIS CHANGE NEEDED?:
      - IndexError raised when NameGrouper used to define a grouper object
        and then when .concat_signal() was invoked
      
      HOW DOES THE CHANGE SOLVE THE PROBLEM?:
      - effectively reverted to aliby@252915c6
      - the two commits leading up to that one solved the problem: first by
        changing chainer's assumption that all experiments have a GFP channel,
        then updated references to renamed variables
      
      WHAT SIDE EFFECTS DOES THIS CHANGE HAVE?:
      - risks: may have broken somewhere upstream not otherwise specified yet
      
      EVIDENCE THAT COMMIT WORKS:
      - running grouper works
      
      REFERENCES:
      - issue #35
      f2102851
  11. Oct 14, 2022
  12. Oct 11, 2022
    • Arin Wongprommoon's avatar
      fix(postproc/chainer): group signals apart from GFP · c361e004
      Arin Wongprommoon authored
      WHY IS THIS CHANGE NEEDED?:
      - grouper (which usues chainer) breaks if it accesses a channel that is
        not GFP
      
      HOW DOES THE CHANGE SOLVE THE PROBLEM?:
      - chainer assumes all experiments have a GFP channel; this was
        hard-coded in line 29 in chainer.py
      
      WHAT SIDE EFFECTS DOES THIS CHANGE HAVE?:
      - yet to test
      
      EVIDENCE THAT COMMIT WORKS:
      - pipelines pending
      
      REFERENCES:
      - ...
      c361e004
  13. Oct 10, 2022
  14. Oct 07, 2022
  15. Oct 05, 2022
Loading