Skip to content
Snippets Groups Projects
  1. Dec 20, 2022
  2. Dec 19, 2022
  3. Dec 01, 2022
  4. Nov 30, 2022
  5. Nov 22, 2022
  6. Oct 27, 2022
  7. Oct 23, 2022
  8. Oct 20, 2022
    • Arin Wongprommoon's avatar
      refactor(postproc): make birth event legend label an argument · 043caf5a
      Arin Wongprommoon authored
      WHY IS THIS CHANGE NEEDED?:
      - when using single_birth_plot routine, user can change the label in
        the legend that indicates birth events
      
      HOW DOES THE CHANGE SOLVE THE PROBLEM?:
      - remove hard-coding of the 'birth event' label by making it an argument
        with the default of 'birth event'.
      - this preserves backwards compatibility as i'm creating a new argument
        and the existing argument names are the same
      
      WHAT SIDE EFFECTS DOES THIS CHANGE HAVE?:
      - backwards compatibility: existing uses of this routine in scripts will
        produce 'budding event' in plots rather than 'birth event'; if a user
        wants to use 'birth event', they can simply define the argument
        birth_label='birth event'.
      
      EVIDENCE THAT COMMIT WORKS:
      - works with a random time series and a binary mask-like numpy array,
        and i can change the legend label
      
      REFERENCES:
      - issue #36
      043caf5a
  9. Oct 18, 2022
  10. Oct 17, 2022
    • Alán Muñoz's avatar
      27b9c3f6
    • Arin Wongprommoon's avatar
      fix(postproc): group signals apart from GFP · f2102851
      Arin Wongprommoon authored
      WHY IS THIS CHANGE NEEDED?:
      - IndexError raised when NameGrouper used to define a grouper object
        and then when .concat_signal() was invoked
      
      HOW DOES THE CHANGE SOLVE THE PROBLEM?:
      - effectively reverted to aliby@252915c6
      - the two commits leading up to that one solved the problem: first by
        changing chainer's assumption that all experiments have a GFP channel,
        then updated references to renamed variables
      
      WHAT SIDE EFFECTS DOES THIS CHANGE HAVE?:
      - risks: may have broken somewhere upstream not otherwise specified yet
      
      EVIDENCE THAT COMMIT WORKS:
      - running grouper works
      
      REFERENCES:
      - issue #35
      f2102851
  11. Oct 14, 2022
  12. Oct 13, 2022
  13. Oct 11, 2022
Loading