Skip to content
Snippets Groups Projects
  1. Aug 11, 2023
  2. Aug 09, 2023
  3. Jun 29, 2023
  4. Mar 17, 2023
  5. Mar 16, 2023
  6. Feb 28, 2023
  7. Feb 27, 2023
  8. Feb 21, 2023
  9. Feb 10, 2023
  10. Jan 12, 2023
  11. Jan 09, 2023
  12. Jan 07, 2023
  13. Jan 04, 2023
  14. Dec 20, 2022
  15. Oct 17, 2022
    • Arin Wongprommoon's avatar
      fix(postproc): group signals apart from GFP · f2102851
      Arin Wongprommoon authored
      WHY IS THIS CHANGE NEEDED?:
      - IndexError raised when NameGrouper used to define a grouper object
        and then when .concat_signal() was invoked
      
      HOW DOES THE CHANGE SOLVE THE PROBLEM?:
      - effectively reverted to aliby@252915c6
      - the two commits leading up to that one solved the problem: first by
        changing chainer's assumption that all experiments have a GFP channel,
        then updated references to renamed variables
      
      WHAT SIDE EFFECTS DOES THIS CHANGE HAVE?:
      - risks: may have broken somewhere upstream not otherwise specified yet
      
      EVIDENCE THAT COMMIT WORKS:
      - running grouper works
      
      REFERENCES:
      - issue #35
      f2102851
  16. Oct 14, 2022
  17. Oct 11, 2022
    • Arin Wongprommoon's avatar
      fix(extraction): define candidate channels · 252915c6
      Arin Wongprommoon authored
      WHY IS THIS CHANGE NEEDED?:
      - invoked grouper (which used chainer, which in turn is based on
        Signal), encountered AttributeError: 'Chainer' object has no
        attributes 'candidate_channels'
      
      HOW DOES THE CHANGE SOLVE THE PROBLEM?:
      - chainer used to rely on av_channels in
        extraction/core/functions/defaults.py, so renamed that to
        candidate_channels
      - added a candidate_channels attribute to Signal object to fulfil references
      252915c6
  18. Oct 04, 2022
  19. Sep 30, 2022
  20. Sep 29, 2022
  21. Sep 28, 2022
  22. Sep 26, 2022
  23. Sep 24, 2022
Loading