Skip to content
Snippets Groups Projects
  1. Jul 26, 2023
    • Arin Wongprommoon's avatar
      fix(postproc): crosscorr catches case where 2nd trace is defined · b88a56f1
      Arin Wongprommoon authored
      WHY IS THIS CHANGE NEEDED?:
      - https://gitlab.com/aliby/aliby/-/jobs/4743945774 complains
        "UnboundLocalError: local variable 'trace_B' referenced before
        assignment".
      - i had forgotten the case where trace_B is defined
      b88a56f1
    • Arin Wongprommoon's avatar
      feat(postproc): crosscorr has stationary option · 97ed1cbb
      Arin Wongprommoon authored
      WHY IS THIS CHANGE NEEDED?:
      - crosscorr process does not have stationary option and therefore will
        not perform calculations correctly if all signals are in-phase.
      
      HOW DOES THE CHANGE SOLVE THE PROBLEM?:
      - Additional 'stationary' parameter that tells the process to compute
        the mean over replicates AND time points.
      
      WHAT SIDE EFFECTS DOES THIS CHANGE HAVE?:
      - crosscorr process not used anywhere else in aliby, so should not
        affect aliby.
      - crosscorr process used in multiple places in skeletons (particularly
        arin's projects).  this is an *additional* parameter, and the existing
        behaviour of crosscorr process is same as stationary=False, so i don't
        expect breaking changes.
      
      EVIDENCE THAT COMMIT WORKS:
      - new test to be run
      
      REFERENCES:
      - #72
      97ed1cbb
  2. Jul 25, 2023
  3. Jul 11, 2023
    • Arin Wongprommoon's avatar
      fix(postproc): detrend process only removes columns with all NaNs · 71150227
      Arin Wongprommoon authored
      WHY IS THIS CHANGE NEEDED?:
      - detrend process overzealously removes columns if input dataframes
        have NaNs near the beginning or end.
      - this is because by default, df.dropna() uses how="any", i.e. it drops
        columns with at least one NaN
      
      HOW DOES THE CHANGE SOLVE THE PROBLEM?:
      - drops columns with at least one NaN is not the intention -- the
        intention is to remove column filled with NaNs created by rolling
        window operations.
      - so, specified the how argument
      
      WHAT SIDE EFFECTS DOES THIS CHANGE HAVE?:
      - i honestly don't know why i didn't catch it in the 1.5 years this
        process existed -- this seems so obvious.
      - this is a deprecated signal processing post-process (i use the
        butterworth filter instead), so i don't expect it to break things much
      
      EVIDENCE THAT COMMIT WORKS:
      71150227
  4. Jun 28, 2023
  5. Jun 27, 2023
  6. May 16, 2023
  7. Apr 04, 2023
  8. Apr 03, 2023
  9. Mar 23, 2023
  10. Mar 21, 2023
  11. Mar 20, 2023
  12. Mar 17, 2023
Loading