Skip to content
Snippets Groups Projects
  1. Oct 20, 2023
  2. Oct 19, 2023
  3. Oct 13, 2023
  4. Oct 12, 2023
  5. Oct 06, 2023
  6. Oct 02, 2023
  7. Sep 29, 2023
  8. Aug 14, 2023
  9. Aug 12, 2023
  10. Aug 11, 2023
  11. Aug 10, 2023
  12. Aug 09, 2023
  13. Aug 07, 2023
  14. Aug 06, 2023
  15. Jul 28, 2023
  16. Jul 26, 2023
  17. Jul 25, 2023
  18. Jul 24, 2023
  19. Jul 21, 2023
  20. Jul 20, 2023
  21. Jul 17, 2023
  22. Jul 12, 2023
  23. Jul 11, 2023
    • Arin Wongprommoon's avatar
      fix(postproc): detrend process only removes columns with all NaNs · 71150227
      Arin Wongprommoon authored
      WHY IS THIS CHANGE NEEDED?:
      - detrend process overzealously removes columns if input dataframes
        have NaNs near the beginning or end.
      - this is because by default, df.dropna() uses how="any", i.e. it drops
        columns with at least one NaN
      
      HOW DOES THE CHANGE SOLVE THE PROBLEM?:
      - drops columns with at least one NaN is not the intention -- the
        intention is to remove column filled with NaNs created by rolling
        window operations.
      - so, specified the how argument
      
      WHAT SIDE EFFECTS DOES THIS CHANGE HAVE?:
      - i honestly don't know why i didn't catch it in the 1.5 years this
        process existed -- this seems so obvious.
      - this is a deprecated signal processing post-process (i use the
        butterworth filter instead), so i don't expect it to break things much
      
      EVIDENCE THAT COMMIT WORKS:
      71150227
Loading